Writing Shell Tests: Difference between revisions

From SambaWiki
(explain that python can do blackbox tests)
(expand and link Avoid bashisms)
Line 9: Line 9:
==Avoid bashisms==
==Avoid bashisms==


On many systems (Debian and Ubuntu in particular)
On many systems ([https://wiki.ubuntu.com/DashAsBinSh Debian and Ubuntu in particular])
/bin/sh
/bin/sh
is actually *dash* not *bash*. Therefore avoid bash specific syntax.
is actually '''dash''' not '''[https://www.gnu.org/software/bash/ Bash]'''. Therefore use only [http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_title.html POSIX sh] and avoid Bash specific syntax.


==Use helper functions==
==Use helper functions==

Revision as of 06:27, 2 August 2017

Writing shell tests

Avoid writing new shell-based tests

New tests should be written in Python.

This includes Black-box tests of Samba binaries using samba.tests.BlackboxTestCase.

Avoid bashisms

On many systems (Debian and Ubuntu in particular)

/bin/sh

is actually dash not Bash. Therefore use only POSIX sh and avoid Bash specific syntax.

Use helper functions

If your test is in testprogs/blackbox you can use:

. `dirname $0`/subunit.sh
. `dirname $0`/common_test_fns.inc

otherwise you will need to use a ../ path to find these.

testit

testit is the primary test command, testing one particular command for success.

testit "change dc password" $samba4srcdir/scripting/devel/chgtdcpass -s $PROVDIR/etc/smb.conf || failed=`expr $failed + 1`

exit code

The script should exit with the number of failures

exit $failed