Writing Shell Tests: Difference between revisions

From SambaWiki
(expand and link Avoid bashisms)
(explain why python is how to blackbox test binaries and samba-tool)
 
Line 5: Line 5:
New tests should be written in [[Writing_Python_Tests|Python]].
New tests should be written in [[Writing_Python_Tests|Python]].


This particularly includes:
This includes [[Writing_Python_Tests#Testing_Samba_binaries|Black-box tests of Samba binaries]] using '''samba.tests.BlackboxTestCase'''.
* [[Writing_Python_Tests#Testing_Samba_binaries|Black-box tests of Samba binaries]] using '''samba.tests.BlackboxTestCase'''
* [[Writing_Python_Tests#Testing_samba-tool|tests of '''samba-tool''']] using '''samba.tests.samba_tool.base.SambaToolCmdTest'''.


==Avoid bashisms==
==Avoid bashisms==

Latest revision as of 06:30, 2 August 2017

Writing shell tests

Avoid writing new shell-based tests

New tests should be written in Python.

This particularly includes:

Avoid bashisms

On many systems (Debian and Ubuntu in particular)

/bin/sh

is actually dash not Bash. Therefore use only POSIX sh and avoid Bash specific syntax.

Use helper functions

If your test is in testprogs/blackbox you can use:

. `dirname $0`/subunit.sh
. `dirname $0`/common_test_fns.inc

otherwise you will need to use a ../ path to find these.

testit

testit is the primary test command, testing one particular command for success.

testit "change dc password" $samba4srcdir/scripting/devel/chgtdcpass -s $PROVDIR/etc/smb.conf || failed=`expr $failed + 1`

exit code

The script should exit with the number of failures

exit $failed