Difference between revisions of "Waf"
m (→ABI Checking)
m (→ABI Checking)
|Line 381:||Line 381:|
signature: int (const void *, const void *)
signature: int (const void *, const void *)
Waf: Leaving directory `/home/tridge/samba/git/combined/lib/talloc/bin'
Waf: Leaving directory `/home/tridge/samba/git/combined/lib/talloc/bin'
Build failed: ABI for libtalloc.so has changed - please fix library version then build with --abi- update
Build failed: ABI for libtalloc.so has changed - please fix library version then build with --abi-update
See http://wiki.samba.org/index.php/Waf#ABI_Checking for more information
See http://wiki.samba.org/index.php/Waf#ABI_Checking for more information
make: *** [all] Error 1
make: *** [all] Error 1
Revision as of 03:07, 18 April 2010
- 1 Using waf to build Samba
- 1.1 Getting the source
- 1.2 Trying it out
- 1.3 Other commands
- 1.4 Developing with waf
- 1.4.1 creating distribution tarballs: waf dist
- 1.4.2 working with libraries
- 1.4.3 controlling rpath
- 1.4.4 Out of tree builds
- 1.4.5 cross-compiling
- 1.4.6 ABI Checking
- 1.5 Packaging with waf
- 1.6 How it works
- 1.7 Documentation
- 2 Parallel builds
- 3 TODO
- 4 COMPLETED TODO ITEMS
- 4.1 speedup null build
- 4.2 fix 'waf test'
- 4.3 check each compiler option
- 4.4 get the waf build working in the build farm
- 4.5 get git revision in logs and -V output
- 4.6 waf configure --help
- 4.7 implement waf install
- 4.8 add --no-bundled-libraries
- 4.9 implement LIBRARY->LIBRARY dependency reduction
- 4.10 make waf builds works from subdirectories
- 4.11 waf dist support
- 4.12 Support waf test --gdb
- 4.13 uuid module
- 4.14 parse MAKEFLAGS
- 4.15 check RPM build of the Samba libs
- 4.16 Add ABI checks to waf dist
Using waf to build Samba
As of March 2010, the waf build of Samba4 is now complete. We also have waf build rules for libreplace, talloc, tdb, tevent, ldb and Samba4. Kai is working on the waf build for Samba3.
- rpath is used so the binaries can be run directly
- building and configuring is fast
- full dependencies are checked, so much less need for make clean
- wrappers are provided for ./configure and make
- builds are much smaller (around 110M versus 1.1G for the old Samba4 build)
- project rules are checked to ensure no object duplication
- supports creation of working tarballs for our standalone libraries
- builds on more build-farm hosts than the existing build system
- much cleaner build rules (in wscript files). Should be easy to learn
Getting the source
The waf build of Samba4 is now in the main 'master' git branch of Samba. So just checkout the git tree as usual.
Trying it out
There are two ways to use the waf build. You can either use the configure wrappers, or you can call waf directly.
Using the configure wrappers
To build Samba4 using the configure wrappers do this:
cd source4 ./autogen-waf.sh ./configure --normal-configure-options make make test
You can also use ./configure.developer as usual.
If you use the configure wrappers then note that the makefile is setup with "JOBS=1" by default. To take advantage of parallel builds, use something like:
Using waf directly
You will probably find it useful to be able to call waf directly, as this offers additional features. To do that follow these steps:
- setup your PATH to point at the buildtools/bin directory
- don't install waf on your system, instead use the one in buildtools/. This ensures we are all always using the same version.
- now try one of the trees that have been converted to waf. For example, to try the tdb tree do this:
cd lib/tdb waf configure --enable-developer --prefix=$HOME/testprefix waf
- that will configure tdb and build the binaries in lib/tdb/bin/. To install them use:
- The other trees that have been converted are lib/replace, lib/talloc, lib/tevent and source4/lib/ldb and source4
Try "waf --help" for help on using waf. Try "waf configure --help" for the equivalent of "./configure --help". I haven't added all of our Samba configuration options yet, but I've put in the most commonly used ones (such as --enable-developer).
You may also find "waf -v" useful for seeing the build commands. Or use "waf -v clean build" to clean and build a tree, with the commands shown. Use "waf -p" to show a progress bar on the build.
This command illustrates the use of multiple build directories:
waf configure --enable-developer -b devbuild
While will set you up for creating the binaries in devbuild instead of the default of bin/.
If you want to debug why something isn't working, then you can either increase the verbosity of waf with something like "waf -vvv", or you can enable tracing of a particular phase of the build. For example, you could trace the build dependencies like this:
waf -v --zone=deps
Developing with waf
With the waf based build we get a number of new features that we didn't have in the old build system.
creating distribution tarballs: waf dist
The waf build automates the process of creating distribution tarballs. It also automatically bundles the needed build tools and the library dependencies. For example:
cd lib/tevent waf dist
Will create tevent-0.9.8.tar.gz. If you unpack that tarball then you'll find it has automatically included the talloc and libreplace libraries in the distribution. It has also setup a autogen-waf.sh which will generate a working configure script and makefile.
The command 'waf distcheck' is also useful. It will create a distribution tarball, then unpack it in a temporary directory, and configure, build and install it (in another temporary directory). It will then run 'waf uninstall' and check that no install files remain.
working with libraries
One of the main challenges we had with the previous build system was how we built and used shared libraries. We had difficulty getting a system in place that worked well both for the package maintainers in distributions, and for people building Samba themselves.
To address these problems the waf build uses a number of strategies:
- rpath is used to make the lives of developers easier
- 'library bundling' is used to ensure libraries don't conflict with system libraries
- configure options are provided to customize the library handling
Perhaps the easiest way to explain the new system is by explaining each of the key configure options, and give common use cases.
The --bundled-libraries option allows you to choose which libraries are 'bundled' with the build. A bundled library is a in-tree library which may have a system equivalent on some systems. The waf build process needs to decide for each library whether it will bundle it or not.
If the configure process does decide to bundle a library, then it will automatically append a suffix onto the library name. The default suffix is the name of the package you are building. For example, if when building Samba4 you bundle the tdb library, then it will build a libtdb-samba4.so shared library.
The reason for the renaming is that it allows the libraries to be installed safely. If we left the name as libtdb.so, then there would be no way (without rpath) to run the newly built tdb library for Samba, but leave the rest of the system using the system supplied tdb library.
The default is to try to use system libraries if they are at least the same version as the in-tree version. This means that if we increase the version number of our in-tree copy of tdb, that we will prefer that in-tree copy as a bundled library until the system version catches up.
The following examples show how to control this process:
waf configure --bundled-libraries=NONE
The 'NONE' option is what many distribution packagers will choose. It tells waf not to bundle any libraries. That means that if the configure process can't find a suitable system library (of the right version) the configure will fail.
waf configure --bundled-libraries=ALL
The 'ALL' option means to bundle all libraries. That means any equivalent system libraries for our in-tree libraries are ignored.
waf configure --bundled-libraries=ldb,NONE
That means to bundle ldb, but to get all other libraries from the system.
waf configure --bundled-libraries=!tdb,ALL
That means to bundle all libraries except tdb. In that case tdb comes from the system.
The bundled library checks also include a library dependency check. It is considered an error to get a library from the system, but to get a dependency of that library as a bundled library. To give an example of why that matters, consider this configure command:
waf configure --bundled-libraries=!tevent,ALL
That would tell configure to bundle all libraries except tevent. The problem with this is that tevent depends on talloc. So if we did used the above settings, then we would end up linking in talloc twice, once from the system libtevent.so, and once from the bundled libtalloc-samba4.so.
The configure process detects this error, and gives an error.
The --builtin-libraries configure option allows you to control what libraries are directly (statically) linked into the program, instead of being linked as shared libraries.
You might, for example, want to link libreplace directly into Samba4, in which case you would use:
waf configure --builtin-libraries=replace
For Samba4 the default is to build all libraries as shared libraries. The default for standalone builds of tdb, talloc, tevent and ldb are to build libreplace as a builtin, with the other dependent libraries built as shared libraries.
All of this is controlled in the wscript files with statements like this:
if conf.CHECK_BUNDLED_SYSTEM('tevent', minversion=VERSION, onlyif='talloc', implied_deps='replace talloc'): conf.define('USING_SYSTEM_TEVENT', 1)
that says that when building a standalone tevent, we should only use the system version of tevent if we also have the system version of talloc.
The --bundled-library-extension option allows you to control the extra extension added to the names of bundled libraries. For example, if you wanted bundled libraries to be called (for example) libldb-s4.so, then use:
waf configure --bundled-library-extension=s4
You can also provide a list of libraries not to apply the extension to. For example:
waf configure --bundled-extension-exception=talloc
would tell configure not to add a bundling extension when building talloc.
By default the waf build will only use an installed system library if it is at least the same version as the in-tree library. This maximizes the chance that the library that is linked to will have been properly tested by the developers.
You can override this choice by using --minimum-library-version, for example:
waf configure --mininum-library-version=talloc:2.0.1,tdb:1.1.5
that would change the minimum library version for talloc to 2.0.1, and for tdb to 1.1.5
It is recommended that you don't use this option without a very good reason, as if you use it you risk creating a build that doesn't incorporate necessary bugfixes from recent changes in the libraries.
The 'rpath' facility of shared libraries and binaries is a way to control where the binary/library goes to look for its dependencies. It is like building a LD_LIBRARY_PATH directly into the binary/library.
rpath is particularly useful for developers, as it allows the running of build binaries without mucking about with LD_LIBRARY_PATH.
The default for the waf build is to use rpath both for the build and the install. This is the most useful option for people who build Samba themselves.
For distribution packagers, rpath is rarely wanted, and is often forbidden. So if you are making a distribution of Samba or one of our standalone libraries, you should use:
waf configure --disable-rpath
You can also disable it just for install, if that is what you prefer:
waf configure --disable-rpath-install
Out of tree builds
waf supports out of tree builds using the -b option to configure. For example:
cd lib/tdb waf configure -b /tmp/tdbbuild waf
That puts all object files, generated files and binaries in /tmp/tdbbuild.
This works nicely for simple packages like tdb, but it gets trickier for full Samba builds. The current problem is with our testsuite, which has some hard-coded places where it assumes binaries in bin/. We also have a problem with the gen_ndr directory, which breaks the out of tree build of IDL files.
In the future we should be able to support out of tree builds for Samba4, but not just yet.
You can build for non-host architectures by using the cross-compilation features of the build. To cross-compile, you will need to install a few things:
- a cross-compiler
- a emulator setup to run cross-compiled binaries
For example, on a Debian derived system for an ARM target you would install gcc-4.3-arm-linux-gnu, linux-kernel-headers-arm-cross and qemu-arm-static. That will give you enough to create ARM binaries.
You may find the following apt sources useful for this:
deb http://mirror.csclub.uwaterloo.ca/emdebian/ stable main deb-src http://mirror.csclub.uwaterloo.ca/emdebian/ stable main
With those installed, you would then configure like this:
CC=arm-linux-gnu-gcc waf configure --cross-compile --cross-execute='qemu-arm-static -L /usr/arm-linux-gnu'
that tells the build to use the arm-linux-gnu-gcc compiler, and to cross-execute the test binaries during the configure stage using the qemu-arm-static tool. By using a --cross-execute tool we can ensure that all our configure tests can run correctly, which avoids the problem of having to guess things like the size of various target architecture types.
After the configure, run waf as usual to build. You can then test the resulting binaries using (for example):
qemu-arm-static -L /usr/arm-linux-gnu bin/ldbadd
and it will run using qemu.
The waf build has the ability to check that developers are not changing the ABI of libraries. This is enabled by default if you use configure with the --enable-developer option, or if you use the --abi-check option. You can disable this ABI checking by using --abi-check-disable
The way the ABI checking works is this:
- A library declaration that uses ABI checking gets two extra options, abi_file and abi_match.
- The ABI signatures are generated using the buildtools/scripts/abi_gen.sh, which uses nm and gdb to generate a set of ABI signatures
- when the library is linked, the build system will check if the ABI signatures have changed. If they have, then it will suggest modifying the major version number if a symbol has been changed or removed, and the minor version number if a symbol has been added. The build will fail.
- if the ABI has changed and the build fails, then you should update the library version (the VERSION variable in the library wscript) and then re-run the build with the --abi-update option. That will regenerate the new signatures file. This should be committed to the git tree.
- ABI checking will only be done if your system supports the -fvisibility=hidden compiler option, as otherwise spurious symbols may appear in the ABI signatures
As an example, if you were to change the 2nd argument of talloc_is_parent() to be non-const, you would see an error message like this:
[13/22] abi_check: lib/talloc/bin/default/lib/talloc/libtalloc.so libtalloc.so: symbol talloc_is_parent has changed - please update major version old_signature: int (const void *, const void *) new_signature: int (const void *, void *) Waf: Leaving directory `/home/tridge/samba/git/combined/lib/talloc/bin' Build failed: ABI for libtalloc.so has changed - please fix library version then build with --abi-update See http://wiki.samba.org/index.php/Waf#ABI_Checking for more information make: *** [all] Error 1
in that case you would need to edit VERSION in lib/talloc/wscript, then run "waf --abi-update" to regenerate the ABI signatures.
If you added a new symbol talloc_is_parent2() then you would see this:
[13/22] abi_check: lib/talloc/bin/default/lib/talloc/libtalloc.so libtalloc.so: symbol talloc_is_parent2 has been added - please mark it _PRIVATE_ or update minor version signature: int (const void *, const void *) Waf: Leaving directory `/home/tridge/samba/git/combined/lib/talloc/bin' Build failed: ABI for libtalloc.so has changed - please fix library version then build with --abi-update See http://wiki.samba.org/index.php/Waf#ABI_Checking for more information make: *** [all] Error 1
in that case you would need to either mark talloc_is_parent2() as being _PRIVATE_, or you could edit VERSION in lib/talloc/wscript, then run "waf --abi-update" to regenerate the ABI signatures.
Here is an example library declaration with ABI checking for talloc:
bld.SAMBA_LIBRARY('talloc', 'talloc.c', deps='replace', abi_file='ABI/talloc-%s.sigs' % VERSION, abi_match='talloc* _talloc*', hide_symbols=True, vnum=VERSION)
this will place the ABI file in ABI/talloc-2.0.2.sigs for the 2.0.2 version of the library. A separate signatures file is generated for each library version. The abi_match option means that only symbols starting with talloc or _talloc will be considered as part of the ABI.
The hide_symbols=True option tells the build to enable the -fvisibility=hidden compiler option (if supported) for building this library. That is used in combination with the _PUBLIC_ and _PRIVATE_ attributes on functions to ensure that symbols are not exposed in libraries when they shouldn't be. The eventual aim will be to enable symbol hiding in all of Samba, but we first need to ensure that all ABI symbols in libraries are marked as _PUBLIC_.
In some cases you want to enable -fvisibility=hidden only when a library is a builtin library. For example, we want to hide symbols from libreplace when it is builtin to another library, but expose them if libreplace is built as a standalone library. To do that use this:
bld.SAMBA_LIBRARY('replace', source=REPLACE_SOURCE, group='base_libraries', hide_symbols=bld.BUILTIN_LIBRARY('replace'), deps='crypt dl nsl socket')
Packaging with waf
If you are the distribution maintainer of one of the packages dervived from the Samba git tree, then you will probably want to use the following configure options:
waf configure --disable-rpath --bundled-libraries=NONE
The above options will disable use of rpath (for both build and install), and will force the use of all system libraries. That means you will first need to ensure that your system has up to date versions of all the dependent libraries, otherwise the configure will fail.
You may also want to control the number of builtin libraries. See the section on builtin libraries above.
Apart from that, packaging with a waf build is very similar to packaging with a autotools based system.
You may also want to add JOBS=4 or similar to the make command to get build parallelism. The makefile based waf build defaults to one CPU.
How it works
Each project within Samba (tdb, ldb, talloc etc) gets a wscript file. That file can depend on other project wscript files. I've kept the wscript files for each project simple by using a 'waf tool' called 'wafsamba', which is in buildtools/wafsamba. Wafsamba is an add-on for waf that sets up the waf configuration and build commands to follow the same sorts of conventions that we have in the existing Samba4 build system.
If you want to have a look at how this was done, then look in buildtools/wafsamba/. You will notice that I've put a lot of paranoia checking in there, as I've found that the exiting config.mk files for the bulk of Samba4 contain some 'interesting' features, such as dependency loops and missing dependencies.
The waf build rules are very simple, and easy to modify. For example:
- the rules for building tdb are here lib/tdb/wscript
- the rules for ldb are here source4/lib/ldb/wscript
- the rules for libreplace, which include most of our configure checks, are here lib/replace/wscript
- the 'wafsamba' waf tool which allows us to describe samba build rules succinctly are here buildtools/wafsamba/wafsamba.py
waf itself is documented in a online book here: http://freehackers.org/~tnagy/wafbook/single.html
The build rules I've added for Samba also need to be documented. I've started this process using pydoctor.
One nice thing about the use of waf is we gain parallel builds. On a 16 CPU machine a complete clean Samba4 build takes just 35s, including rebuilding all of the IDL files. It takes over 5 minutes on the same machine with the old build system.
Here is a graph of the build time versus -j flag
and here is a picture which shows the degrees of parallelism at different points in the build with 4 CPUs
A short list of work items, not complete!
detect system changes
It would be nice to detect changing system headers/libraries and give an error at build stage
detect configure changes
We need to detect configure related changes to wscripts and give an error at build stage.
Rules for yapp, yacc and lex
We need rules to regenerate files with yapp (for pidl) if the grammar has changed.
We need rules to regenerate files with yacc and lex (for heimdal), here we need to only allow trusted combinations of bison and flex.
If the system has this tools we need to have rules for them, otherwise we need a way to give an error if the "source" has changed but we're not able to regenerate.
update: done for yapp
Run autogen-waf.sh within waf dist
Tarballs should come with ./configure already available, run autogen-waf.sh as part of waf dist so that the only thing users need to do is ./configure && make
support public_deps symbol hiding
We need to use the linker scripts to hide non-public symbols in libraries
The AIX, IRIX and TRU64 compilers can generate shared libs. We need to support that and test that it works correctly.
implement the non-emulator based cross-compile method
COMPLETED TODO ITEMS
speedup null build
the null build now takes about 1.6s which is good enough
fix 'waf test'
all s4 tests now pass with the waf build
check each compiler option
for options like --enable-developer we need to check the compiler supports the various options.
The flags should only be used in the build and not within configure checks.
get the waf build working in the build farm
This will test the portability quite well
its passing on some hosts in the build farm. The others are being worked on
get git revision in logs and -V output
bin/samba -V should show the git revision
waf configure --help
waf configure --help should display 'build' as possible command
implement waf install
We need to call the same install scripts we used from the old build, at least initially.
all done now
done, as --bundled-libraries=LIST
implement LIBRARY->LIBRARY dependency reduction
We want object files used in common between libraries that depend on each other to be removed from the parent library, unless the parent library exports the symbols publicly and the child library is a private library
done. Installed size of s4 with waf is now down to about 110M
make waf builds works from subdirectories
You could be able to "cd source4/client" and run waf
waf dist support
done. We now build working tarballs for tdb, ldb, talloc, replace, tevent and samba4
Support waf test --gdb
We need to have a replacement for the old 'make gdbtest' and 'make gdbtest-env'.
The uuid module in scripting/python should only be built if the python version in use is <= 2.4. Newer versions of Python include this module.
If someone uses 'make -j N' then that sets MAKEFLAGS in waf. It would be nice to parse that and setup the right number of jobs, for people who want to do parallel builds with 'make' instead of 'waf'
done: we parse -j and -k now
check RPM build of the Samba libs
check that the spec files work with minimal changes
done: working spec files sent to Simo
Add ABI checks to waf dist
When preparing releases make sure ABI/API are checked for breakage so that it can be handled appropriately by either fixing the code or eventually increasing the .so version for libraries marked stable.
done: see ABI Checking above