Difference between revisions of "Creating a Samba patch series"

From SambaWiki
(Created page with "= Introduction = When contributing to Samba, there are quality expectations that need to be met in order for your patches to be accepted. Please review these guidelines ''bef...")
 
Line 9: Line 9:
 
== What a commit should include ==
 
== What a commit should include ==
   
Each git commit should be succinct and only do one thing.
+
Each git commit should be succinct and only do one thing. The problem with merge requests is that the '''Changes''' view shows a complete product, but in Samba, we also care about the history when getting to the final product.

Revision as of 18:16, 15 June 2020

Introduction

When contributing to Samba, there are quality expectations that need to be met in order for your patches to be accepted. Please review these guidelines before writing your first commits, otherwise you may need to rebase your patches.

What this page is not

This page is not meant to be a technical overview about using git, there are already plenty of resources for learning to use git. It's expected when you reach this page that you already know these concepts.

What a commit should include

Each git commit should be succinct and only do one thing. The problem with merge requests is that the Changes view shows a complete product, but in Samba, we also care about the history when getting to the final product.